fix(rgb): set ext_power during init and settings restoration#3231
Draft
veypatch wants to merge 1 commit intozmkfirmware:mainfrom
Draft
fix(rgb): set ext_power during init and settings restoration#3231veypatch wants to merge 1 commit intozmkfirmware:mainfrom
veypatch wants to merge 1 commit intozmkfirmware:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #3155
This PR ensures that the External Power (ext_power) state is correctly set with the RGB Underglow state. It addresses two distinct issues:
CONFIG_ZMK_RGB_UNDERGLOW_ON_START=nis set as ext_power defaults to on.I still need to verify these changes across different scenarios to ensure no other side effects were introduced so I'm opening this as a draft for now.
PR check-list